Merge pull request 'Bluetoothの判定処理が正しく行われていないバグを修正' (#33) from hotfix-Bluetooth into main

Reviewed-on: #33

app/src/main/AndroidManifest.xml

@@ -35,7 +35,7 @@
                 <category android:name="android.intent.category.LAUNCHER" />
             </intent-filter>
         </activity>
-        <service android:name=".TestService" />
+        <service android:name=".SurveillanceService" />
     </application>
 
 </manifest>

app/src/main/java/com/example/childguard/HomeFragment.java

@@ -31,6 +31,9 @@ public class HomeFragment extends Fragment implements OnEventListener {
     private String str_key;
     private String mParam2;
 
+    final String GET_ON = "\n乗車状態";
+    final String GET_OFF = "\n降車状態";
+
 
     public HomeFragment() {
         // Required empty public constructor
@@ -107,6 +110,9 @@ public class HomeFragment extends Fragment implements OnEventListener {
         transaction.commit();
     }
 
+    /**
+     * 乗車状態の画面を切り替える
+     */
     private boolean updateUiState(boolean isInCar) {
         Log.d("HomeFragment", "updateUiState: called");
         // Init
@@ -124,29 +130,31 @@ public class HomeFragment extends Fragment implements OnEventListener {
             updateUiState(isInCar);
             return false;
         }
-        String get_on = "\n乗車状態";
-        String get_off = "\n降車状態";
+
         if (!isInCar) {
             //乗車状態にする
             fl.setBackground(ResourcesCompat.getDrawable(getResources(), R.drawable.frame_style_orange, null));
-            tv.setText(get_on);
+            tv.setText(GET_ON);
         } else {
             //降車状態にする
             fl.setBackground(ResourcesCompat.getDrawable(getResources(), R.drawable.frame_style, null));
-            tv.setText(get_off);
+            tv.setText(GET_OFF);
         }
 
         return true;
     }
 
+    /**
+     * Bluetoothの接続状態の画面を切り替える
+     */
     private boolean updateBluetoothSituation(Boolean BluetoothConnect) {
         FrameLayout frameLayout;
         TextView textView;
         ImageView imageView;
         try {
-            frameLayout = requireView().findViewById(R.id.situation_bg2);
-            textView = requireView().findViewById(R.id.Bluetoothsituation);
-            imageView = requireView().findViewById(R.id.Bluetoothsituationimage);
+            frameLayout = requireView().findViewById(R.id.situation_bg_bluetooth);
+            textView = requireView().findViewById(R.id.BluetoothSituation);
+            imageView = requireView().findViewById(R.id.BluetoothSituationImage);
         } catch (NullPointerException e) {
             Log.d("HomeFragment", "updateUiState: view is null");
             return false;
@@ -156,17 +164,17 @@ public class HomeFragment extends Fragment implements OnEventListener {
             updateBluetoothSituation(BluetoothConnect);
             return false;
         }
-        String connect = "接続中";
-        String disconnect = "切断中";
+        final String CONNECT = "接続中";
+        final String DISCONNECT = "切断中";
         if (BluetoothConnect) {
             //接続状態にする
             frameLayout.setBackground(ResourcesCompat.getDrawable(getResources(), R.drawable.frame_style_orange, null));
-            textView.setText(connect);
+            textView.setText(CONNECT);
             imageView.setVisibility(View.GONE);
         } else {
-            //降車状態にする
+            //切断状態にする
             frameLayout.setBackground(ResourcesCompat.getDrawable(getResources(), R.drawable.frame_style, null));
-            textView.setText(disconnect);
+            textView.setText(DISCONNECT);
             imageView.setVisibility(View.VISIBLE);
         }
 

app/src/main/java/com/example/childguard/MainActivity.java

@@ -14,7 +14,6 @@ import android.content.pm.PackageManager;
 import android.graphics.Color;
 import android.os.Build;
 import android.os.Bundle;
-import android.os.Handler;
 import android.os.Vibrator;
 import android.preference.PreferenceManager;
 import android.util.Log;
@@ -52,7 +51,6 @@ public class MainActivity extends AppCompatActivity {
     public static final String TAG = "InspirationQuote";
 
 
-
     private final ActivityResultLauncher<ScanOptions> QrLauncher = registerForActivityResult(
             new ScanContract(),
             result -> {
@@ -76,10 +74,9 @@ public class MainActivity extends AppCompatActivity {
         setContentView(R.layout.activity_main);
 
         //Bluetooth接続判定用
-        SharedPreferences pref=PreferenceManager.getDefaultSharedPreferences(this);
-        SharedPreferences.Editor e=pref.edit();
-        e.putBoolean("connection_status",false);
-
+        SharedPreferences pref = PreferenceManager.getDefaultSharedPreferences(this);
+        SharedPreferences.Editor e = pref.edit();
+        e.putBoolean("connection_status", false);
 
 
         if (!hasPermissions()) {
@@ -136,7 +133,7 @@ public class MainActivity extends AppCompatActivity {
         }
         registerReceiver(receiver, intentFilter);
 
-        startForegroundService(new Intent(this, TestService.class));
+        startForegroundService(new Intent(this, SurveillanceService.class));
 
     }
 
@@ -187,7 +184,6 @@ public class MainActivity extends AppCompatActivity {
                 }
             }
         });
-
     }
 
     private boolean hasPermissions() {
@@ -229,22 +225,24 @@ public class MainActivity extends AppCompatActivity {
     }
 
 
-
-
+    /**
+     * FireBaseのIDの取得
+     */
     public void firebaseLink() {//Firebaseのドキュメントの取得
         //共有プリファレンス全体の準備
         SharedPreferences sharedPreferences = getSharedPreferences("app_situation", MODE_PRIVATE);
-        String IdPref = sharedPreferences.getString("ID", null);////アプリに記録されているIDの取得
+        String IdPref = sharedPreferences.getString("ID", null);//アプリに記録されているIDの取得
         if (IdPref == null) {//FireBaseのIDがアプリに登録されているとき
             Log.d("onResume", "ID not initialized.");
         } else {
             mDocRef = FirebaseFirestore.getInstance().document("status/" + IdPref);//現在の位置を取得
             initNotification(mDocRef);//現在の位置を引数に initNotification()を処理
-
         }
     }
-
-    public void ResetReported() {//FireBaseのisReportedをfalseに初期化するメソッド
+    /**
+     * FireBaseのisReportedをfalseに初期化するメソッド
+     */
+    public void ResetReported() {
         //共有プリファレンス全体の準備
         SharedPreferences sharedPreferences = MainActivity.this.getSharedPreferences("app_situation", MODE_PRIVATE);
         String IdPref = sharedPreferences.getString("ID", null);//アプリに記録されているIDの取得
@@ -255,25 +253,32 @@ public class MainActivity extends AppCompatActivity {
         isReported.update("isReported", false).addOnSuccessListener(unused -> Log.d(TAG, "DocumentSnapshot successfully updated!")).addOnFailureListener(e -> Log.w(TAG, "Error updating document", e));
     }
 
+    /**
+     * 乗車状態の変更
+     */
     public void changeIsInCar() {
         //共有プリファレンス全体の準備
         SharedPreferences sharedPreferences = MainActivity.this.getSharedPreferences("app_situation", MODE_PRIVATE);
         //共有プリファレンス 書き込みの準備
         SharedPreferences.Editor E = sharedPreferences.edit();
         String IdPref = sharedPreferences.getString("ID", null);//アプリに記録されているIDの取得
-        Boolean change=sharedPreferences.getBoolean("change",false);
+        Boolean change = sharedPreferences.getBoolean("change", false);
         db = FirebaseFirestore.getInstance();//Firebaseとの紐づけ
         DocumentReference isReported = db.collection("status").document(IdPref);//更新するドキュメントとの紐づけ
         Map<String, Boolean> DEFAULT_ITEM = new HashMap<>();//mapの宣言
         if (!change) {
             //isInCarをtrueに更新
-            E.putBoolean("change",true);
-        }else{
-            E.putBoolean("change",false);
+            E.putBoolean("change", true);
+        } else {
+            E.putBoolean("change", false);
         }
         isReported.update("isInCar", change).addOnSuccessListener(unused -> Log.d(TAG, "DocumentSnapshot successfully updated!")).addOnFailureListener(e -> Log.w(TAG, "Error updating document", e));
         E.apply();
     }
+
+    /**
+     * 第三者通知に関する設定のメソッド
+     */
     public void NotificationSetting() {//通知に関する設定の処理を行うメソッド
         int importance = NotificationManager.IMPORTANCE_DEFAULT;
         //通知チャネルの実装
@@ -282,9 +287,11 @@ public class MainActivity extends AppCompatActivity {
 
         NotificationManager notificationManager = getSystemService(NotificationManager.class);
         notificationManager.createNotificationChannel(channel);
-
     }
 
+    /**
+     * 第三者通知を行うメソッド
+     */
     public void Notification(Context context) {//実際に通知を行うメソッド
         final String CHANNEL_ID = "my_channel_id";
         // 通知がクリックされたときに送信されるIntent
@@ -332,63 +339,52 @@ public class MainActivity extends AppCompatActivity {
         notificationManager.notify(R.string.app_name, builder.build());//通知の表示
     }
 
-
-    @Override
-    public void onStop() {//アプリをバックグラウンドにした時のメソッド
-        super.onStop();
-//        Intent intent = new Intent(getApplication(), TestService.class);
-//        startService(intent);//TestServiceを起動
-    }
-
-    public void NotificationBluetooth(Context context) {//実際に通知を行うメソッド
-        final String CHANNEL_ID = "my_channel_id";
-        // 通知がクリックされたときに送信されるIntent
-        Intent intent = new Intent(context, MainActivity.class);
-        intent.setAction("OPEN_ACTIVITY");
-        // PendingIntentの作成
-        int requestCode = 100;
-        int flags = 0;
-        PendingIntent pendingIntent = PendingIntent.getActivity(context, requestCode, intent, flags | PendingIntent.FLAG_IMMUTABLE);
-
-        ((Vibrator) getSystemService(Context.VIBRATOR_SERVICE)).vibrate(2000);//バイブレーション
-
-        @SuppressLint("NotificationTrampoline") NotificationCompat.Builder builder = new NotificationCompat.Builder(context, "CHANNEL_ID")
-                .setSmallIcon(android.R.drawable.ic_menu_info_details)
-                .setContentTitle("子供の置き去りをしていませんか？")//通知のタイトル
-                .setContentText("Bluetoothと車の切断から5分が経過しました")//通知の本文
-                .setContentIntent(pendingIntent)//通知をタップするとActivityへ移動する
-                .setAutoCancel(true)//通知をタップすると削除する
-                .setPriority(NotificationCompat.PRIORITY_HIGH) // プライオリティを高く設定
-                .setVisibility(NotificationCompat.VISIBILITY_PUBLIC); // ロック画面に表示する
-
-        // NotificationChannelの作成（Android 8.0以降）
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
-            NotificationManager notificationManager = context.getSystemService(NotificationManager.class);
-            if (notificationManager != null) {
-                NotificationChannel channel = new NotificationChannel(
-                        CHANNEL_ID,
-                        "Channel Name",
-                        NotificationManager.IMPORTANCE_HIGH
-                );
-
-                channel.setDescription("Channel Description");
-                channel.enableLights(true);
-                channel.setLightColor(Color.RED);
-                channel.enableVibration(true);
-                notificationManager.createNotificationChannel(channel);
-            }
-        }
-
-
-        NotificationManager notificationManager = (NotificationManager)context.getSystemService(context.NOTIFICATION_SERVICE);
-        if (ActivityCompat.checkSelfPermission(this, android.Manifest.permission.POST_NOTIFICATIONS) != PackageManager.PERMISSION_GRANTED) {
-            return;
-        }
-        notificationManager.notify(R.string.app_name, builder.build());//通知の表示
-    }
-
-
-
+//    public void NotificationBluetooth(Context context) {//実際に通知を行うメソッド
+//        final String CHANNEL_ID = "my_channel_id";
+//        // 通知がクリックされたときに送信されるIntent
+//        Intent intent = new Intent(context, MainActivity.class);
+//        intent.setAction("OPEN_ACTIVITY");
+//        // PendingIntentの作成
+//        int requestCode = 100;
+//        int flags = 0;
+//        PendingIntent pendingIntent = PendingIntent.getActivity(context, requestCode, intent, flags | PendingIntent.FLAG_IMMUTABLE);
+//
+//        ((Vibrator) getSystemService(Context.VIBRATOR_SERVICE)).vibrate(2000);//バイブレーション
+//
+//        @SuppressLint("NotificationTrampoline") NotificationCompat.Builder builder = new NotificationCompat.Builder(context, "CHANNEL_ID")
+//                .setSmallIcon(android.R.drawable.ic_menu_info_details)
+//                .setContentTitle("子供の置き去りをしていませんか？")//通知のタイトル
+//                .setContentText("Bluetoothと車の切断から5分が経過しました")//通知の本文
+//                .setContentIntent(pendingIntent)//通知をタップするとActivityへ移動する
+//                .setAutoCancel(true)//通知をタップすると削除する
+//                .setPriority(NotificationCompat.PRIORITY_HIGH) // プライオリティを高く設定
+//                .setVisibility(NotificationCompat.VISIBILITY_PUBLIC); // ロック画面に表示する
+//
+//        // NotificationChannelの作成（Android 8.0以降）
+//        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+//            NotificationManager notificationManager = context.getSystemService(NotificationManager.class);
+//            if (notificationManager != null) {
+//                NotificationChannel channel = new NotificationChannel(
+//                        CHANNEL_ID,
+//                        "Channel Name",
+//                        NotificationManager.IMPORTANCE_HIGH
+//                );
+//
+//                channel.setDescription("Channel Description");
+//                channel.enableLights(true);
+//                channel.setLightColor(Color.RED);
+//                channel.enableVibration(true);
+//                notificationManager.createNotificationChannel(channel);
+//            }
+//        }
+//
+//
+//        NotificationManager notificationManager = (NotificationManager) context.getSystemService(context.NOTIFICATION_SERVICE);
+//        if (ActivityCompat.checkSelfPermission(this, android.Manifest.permission.POST_NOTIFICATIONS) != PackageManager.PERMISSION_GRANTED) {
+//            return;
+//        }
+//        notificationManager.notify(R.string.app_name, builder.build());//通知の表示
+//    }
 
 
     public void Bluetooth_status() {
@@ -413,8 +409,8 @@ public class MainActivity extends AppCompatActivity {
 
         @Override
         public void onReceive(Context context, Intent intent) {
-            SharedPreferences pref=getSharedPreferences("Bluetooth_situation",MODE_PRIVATE);
-            SharedPreferences.Editor e=pref.edit();
+            SharedPreferences pref = getSharedPreferences("Bluetooth_situation", MODE_PRIVATE);
+            SharedPreferences.Editor e = pref.edit();
             String action = intent.getAction(); // may need to chain this to a recognizing function
             BluetoothDevice device = intent.getParcelableExtra(BluetoothDevice.EXTRA_DEVICE);
             Boolean isInCar = pref.getBoolean("isInCarPref", false);
@@ -427,9 +423,7 @@ public class MainActivity extends AppCompatActivity {
             String registeredId = PreferenceManager.getDefaultSharedPreferences(getApplicationContext()).getString("bluetooth_device_id", "none");
 
             if (BluetoothDevice.ACTION_ACL_CONNECTED.equals(action)) {
-                //Do something if connected
                 //Bluetoothデバイスが接続されたときの処理
-                changeBluetooth(true);
                 Log.d("BT", "Device connected");
 
                 Log.d("BT_Judge", "Registered: " + registeredId);
@@ -437,40 +431,28 @@ public class MainActivity extends AppCompatActivity {
                 if (deviceHardwareAddress.equals(registeredId)) {
                     //登録済みのデバイスだったときの処理
                     Log.d("BT_Judge", "登録済み");
-                    e.putBoolean("connection_status",true);
+                    changeBluetooth(true);
+                    e.putBoolean("connection_status", true);
 
-                } else{
+                } else {
                     //登録していないデバイスだったときの処理
                     Log.d("BT_Judge", "未登録");
-                    e.putBoolean("connection_status",false);
+                    e.putBoolean("connection_status", false);
                 }
                 e.apply();
 
-            } else if (BluetoothDevice.ACTION_ACL_DISCONNECTED.equals(action)&&!isInCar) {//bluetoothが切断されたときに乗車状態のとき
-
-                //Do something if disconnected
-                //デバイスが切断されたときの処理
+            }else if (BluetoothDevice.ACTION_ACL_DISCONNECTED.equals(action)) {
+                //bluetoothデバイスが切断されたときの処理
                 changeBluetooth(false);
-                if (deviceHardwareAddress.equals(registeredId)) {
-                    // 5分待機する
-                    Handler handler = new Handler();
-                    handler.postDelayed(new Runnable() {
-                        @Override
-                        public void run() {
-                            if (BluetoothDevice.ACTION_ACL_DISCONNECTED.equals(action)&&!isInCar) {//その後bluetoothを再接続したり降車状態になったりしていない＝置き去りが発生した可能性大
-                                NotificationBluetooth(getApplicationContext());//通知を行うメソッド
-                            }}
-
-                    }, 5 *60*1000); // 5分をミリ秒に変換
-                }
-            }else {
-                Log.d("BT", "Device disconnected");
             }
         }
     };
 
-    public void changeBluetooth(boolean actual){
-        getSharedPreferences("Bluetooth_situation",MODE_PRIVATE).edit().putBoolean("status",actual).apply();
+    /**
+     * Bluetoothの接続状態を変更するメソッド
+     */
+    public void changeBluetooth(boolean actual) {
+        getSharedPreferences("Bluetooth_situation", MODE_PRIVATE).edit().putBoolean("status", actual).apply();
     }
 }
 

app/src/main/java/com/example/childguard/SettingFragment.java

@@ -3,6 +3,8 @@ package com.example.childguard;
 import static android.content.ContentValues.TAG;
 import static android.content.Context.MODE_PRIVATE;
 
+import android.content.Context;
+import android.content.Intent;
 import android.content.SharedPreferences;
 import android.os.Bundle;
 import android.util.Log;
@@ -95,6 +97,7 @@ public class SettingFragment extends Fragment {
                             SharedPreferences.Editor editor = sharedPreferences1.edit();
                             editor.putString("ID", documentReference.getId());
                             editor.apply();
+                            startTestService();
 
                             Toast.makeText(getActivity(), "初回登録", Toast.LENGTH_SHORT).show();
                             getParentFragmentManager().beginTransaction().addToBackStack(null).replace(R.id.fragmentContainerView, GenerateQrFragment.newInstance(documentReference.getId())).commit();
@@ -106,4 +109,11 @@ public class SettingFragment extends Fragment {
             }
         });
     }
+    private void startTestService() {
+        Context context = getContext();
+        if (context != null) {
+            Intent serviceIntent = new Intent(context, SurveillanceService.class);
+            context.startForegroundService(serviceIntent);
+        }
+    }
 }

app/src/main/java/com/example/childguard/SurveillanceService.java

@@ -27,7 +27,7 @@ import androidx.core.app.NotificationManagerCompat;
 import com.google.firebase.firestore.DocumentReference;
 import com.google.firebase.firestore.FirebaseFirestore;
 
-public class TestService extends Service {
+public class SurveillanceService extends Service {
 
     private final Handler handler = new Handler();
     private Runnable notificationRunnable;
@@ -73,12 +73,13 @@ public class TestService extends Service {
     private static final NotificationContent REPORTED_NOTIFICATION =
             new NotificationContent("子供の置き去りをしていませんか？", "第三者からの通報が行われました。", REPORTED_CHANNEL_ID, 2);
     private static final NotificationContent BLUETOOTH_NOTIFICATION =
-            new NotificationContent("子供の置き去りをしていませんか？", "Bluetoothと車の切断から5分が経過しました", BT_ALERT_CHANNEL_ID, 3);
+            new NotificationContent("子供の置き去りをしていませんか？🐈", "Bluetoothと車の切断から5分が経過しました", BT_ALERT_CHANNEL_ID, 3);
 
     private String userId = null;
 
     @Override
     public int onStartCommand(Intent intent, int flags, int startId) {
+        Log.d(TAG, "onStartCommand: ");
         this.userId = getSharedPreferences("app_situation", MODE_PRIVATE).getString("ID", null);
         if (this.userId == null) {
             Log.d("onResume", "ID not initialized.");
@@ -254,7 +255,7 @@ public class TestService extends Service {
     private PendingIntent getPendingIntent(Context context) {
         Intent intent = new Intent(context, MainActivity.class);
         intent.setAction("OPEN_ACTIVITY");
-        return PendingIntent.getActivity(context, TestService.REQUEST_CODE, intent, PendingIntent.FLAG_IMMUTABLE);
+        return PendingIntent.getActivity(context, SurveillanceService.REQUEST_CODE, intent, PendingIntent.FLAG_IMMUTABLE);
     }
 
     /**
@@ -315,13 +316,18 @@ public class TestService extends Service {
                 Log.d("BT_Judge", "Not registered device");
                 return;
             }
-            boolean isInCar = getSharedPreferences("Bluetooth_situation", MODE_PRIVATE).getBoolean("isInCarPref", false);
+            boolean isInCar = !getSharedPreferences("app_situation", MODE_PRIVATE).getBoolean("change", false);
             if (!isInCar) {
                 Log.d("BT_Judge", "Not in car");
                 return;
             }
             // -----------------------------------------------------
 
+            // debug log
+            Log.d("BT", "Bluetooth device found: " + deviceHardwareAddress);
+            Log.d("BT", "Registered device: " + registeredId);
+            Log.d("BT", "Is in car: " + isInCar);
+
             String action = intent.getAction(); // may need to chain this to a recognizing function
             if (BluetoothDevice.ACTION_ACL_DISCONNECTED.equals(action)) {
                 // bluetoothが切断されたときに乗車状態のとき

app/src/main/res/layout/fragment_home.xml

@@ -49,7 +49,7 @@
         </FrameLayout>
 
         <FrameLayout
-            android:id="@+id/situation_bg2"
+            android:id="@+id/situation_bg_bluetooth"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_marginLeft="20dp"
@@ -58,7 +58,7 @@
             android:background="@drawable/frame_style">
 
             <TextView
-                android:id="@+id/Bluetoothsituation"
+                android:id="@+id/BluetoothSituation"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:layout_marginTop="5dp"
@@ -75,7 +75,7 @@
                 android:textAlignment="center" />
 
             <ImageView
-                android:id="@+id/Bluetoothsituationimage"
+                android:id="@+id/BluetoothSituationImage"
                 android:layout_width="match_parent"
                 android:layout_height="100dp"
                 android:layout_marginTop="50dp"